fix: ignore inactive remote URL conflicts#1317
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1193.
Remote URL uniqueness validation already excluded deleted servers at the query layer, but deprecated servers were still treated as conflicts. That blocks publishing a replacement server when the old server has intentionally been deprecated.
This change keeps the existing same-server exemption and skips inactive registry entries before reporting a remote URL conflict. The regression test creates a deprecated server that owns a remote URL, then verifies a different replacement server can reuse that URL.
Validation
Passed:
gofmt -w internal\service\registry_service.go internal\service\registry_service_test.gogo test ./internal/service -run '^$' -count=1git diff --checkBlocked locally:
go test ./internal/service -run TestValidateNoDuplicateRemoteURLs -count=1go test ./internal/service -run 'TestUpdateServerStatus_ValidateRemoteURLsOnRestore|TestUpdateAllVersionsStatus_ValidateRemoteURLsOnRestore' -count=1Both targeted test commands require a local PostgreSQL test database. This Windows clean clone does not have Docker/PostgreSQL available, and the test helper failed before executing the test body with:
Failed to connect to PostgreSQL. Make sure PostgreSQL is running via: docker-compose up -d postgres.